cluster-api-provider-openstack icon indicating copy to clipboard operation
cluster-api-provider-openstack copied to clipboard

[WIP] ⚠️ General API cleanup

Open mdbooth opened this issue 1 year ago • 6 comments

This series of commits is intended to make the marshalling of our API objects more deterministic. It primarily consists of:

  • making optional fields into pointers
  • giving non-optional fields explicit defaults where possible

/hold

mdbooth avatar Feb 21 '24 11:02 mdbooth

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Feb 21 '24 11:02 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
Latest commit bc9c5dfcaf323831d752f33c355ea6d37cdaddf3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65e23547b86f4900081d60e1
Deploy Preview https://deploy-preview-1897--kubernetes-sigs-cluster-api-openstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 21 '24 11:02 netlify[bot]

Sorry for the merge conflict, it's due to the Security group stuff. Let me know if you need help...

EmilienM avatar Feb 21 '24 15:02 EmilienM

/approve cancel

mdbooth avatar Feb 22 '24 10:02 mdbooth

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 22 '24 10:02 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 04 '24 18:03 k8s-ci-robot

This turned in many, many other PRs.

mdbooth avatar Apr 01 '24 08:04 mdbooth