🐛 no more reconcileExternalnetwork when not use external network

[ruifaling]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1490

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [ ] squashed commits
• if necessary:
  • [ ] includes documentation
  • [ ] adds unit tests

/hold

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	0f8dd207bae342ac7aafe0b94db77203e2e3744b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64a3decc3a58a70007220890
😎 Deploy Preview	https://deploy-preview-1597--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Hi @ruifaling. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruifaling Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[ruifaling]

@mdbooth @jichenjc @tobiasgiese Because the previous pr code has fallen too far behind, I resubmit the new pr,please have a re-review

The previous one is https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1491

[dulek]

/lgtm

[ruifaling]

/re-test

[jichenjc]

/retest

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[mdbooth]

/ok-to-test

[mdbooth]

@EmilienM Does your external network change resolve this?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EmilienM]

@EmilienM Does your external network change resolve this?

We now provide a way to disable the external network bits: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/622defd0bd6fa3f28f4672a1c309a71c55f4529c/docs/book/src/topics/crd-changes/v1alpha7-to-v1alpha8.md?plain=1#L90-L93

[EmilienM]

@mdbooth I suggest we close this one. We now have a way to disable ExternalNetwork. The PR here makes it for the user but like you said this might not work fine for the bastion.