cluster-api-provider-nested icon indicating copy to clipboard operation
cluster-api-provider-nested copied to clipboard

🐛 ClusterVersion CRD gets rejected on k8 v1.20.2

Open mazocode opened this issue 4 years ago • 3 comments

The ClusterVersion CRD is using apiVersion v1beta1 which requires properties in x-kubernetes-list-map-keys to be required (validation was introduced with https://github.com/kubernetes/kubernetes/pull/88076/commits/2e187415fd582ea80bc316fb76cb30c3ad1aead4). v1 supports defaults too.

A manual rebuild with a newer controller-gen (I've used controller-tools 0.5.0) using controller-gen "crd:trivialVersions=true,maxDescLen=0" rbac:roleName=manager-role paths="./..." output:crd:artifacts:config=config/crds creates an accepted CRD with the v1 CRD API.

Unfortunately, the CRD generated from make build is broken (contains an invalid validation: section) with newer controller-tools installed. I guess the reason is replace-null in hack/lib/util.sh.

mazocode avatar May 19 '21 20:05 mazocode

/retitle 🐛 ClusterVersion CRD gets rejected on k8 v1.20.2

christopherhein avatar Jun 10 '21 07:06 christopherhein

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 08 '21 08:09 k8s-triage-robot

/remove-lifecycle stale /lifecycle frozen

christopherhein avatar Sep 08 '21 22:09 christopherhein