cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Deprecate SSHKeys in favor of SSHKeysRef variable

Open Prajyot-Parab opened this issue 2 years ago • 3 comments

Signed-off-by: Prajyot-Parab [email protected]

What this PR does / why we need it:

  • Deprecate SSHKeys in favor of SSHKeysRef variable

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Deprecate SSHKeys in favor of SSHKeysRef variable

Prajyot-Parab avatar Oct 14 '22 14:10 Prajyot-Parab

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 3f4f930c3659cc34e4d7b403770a6c05fc423b76
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/637254e4760fec00089546f9
Deploy Preview https://deploy-preview-920--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 14 '22 14:10 netlify[bot]

/cc @mkumatag @Amulyam24

Prajyot-Parab avatar Oct 14 '22 15:10 Prajyot-Parab

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval by writing /assign @mkumatag in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 26 '22 05:10 k8s-ci-robot

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Nov 07 '22 18:11 k8s-ci-robot

/cc @Amulyam24 @mkumatag did code changes as per our discussion.

Prajyot-Parab avatar Nov 07 '22 18:11 Prajyot-Parab

overall lgtm, how about adding some UT around this?

Done.

Prajyot-Parab avatar Nov 14 '22 14:11 Prajyot-Parab

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 15 '22 07:11 k8s-ci-robot