cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

Migrate Ginkgo from v1 to v2

Open mkumatag opened this issue 2 years ago • 5 comments

/kind feature /area provider/ibmcloud

Describe the solution you'd like As Ginkgo v1 is deprecated and seen this following deprecated notice in our most of the e2e test reports, so we need to migrate to v2 version

[38;5;228mYou're using deprecated Ginkgo functionality:[0m
[38;5;228m=============================================[0m
[1m[38;5;10mGinkgo 2.0[0m is under active development and will introduce several new features, improvements, and a small handful of breaking changes.
A release candidate for 2.0 is now available and 2.0 should GA in Fall 2021.  [1mPlease give the RC a try and send us feedback![0m
  - To learn more, view the migration guide at [38;5;14m[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md[0m
  - For instructions on using the Release Candidate visit [38;5;14m[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta[0m
  - To comment, chime in at [38;5;14m[4mhttps://github.com/onsi/ginkgo/issues/711[0m

  [38;5;11mYou are using a custom reporter.  Support for custom reporters will likely be removed in V2.  Most users were using them to generate junit or teamcity reports and this functionality will be merged into the core reporter.  In addition, Ginkgo 2.0 will support emitting a JSON-formatted report that users can then manipulate to generate custom reports.

  [38;5;9m[1mIf this change will be impactful to you please leave a comment on [38;5;14m[4mhttps://github.com/onsi/ginkgo/issues/711[0m[0m
  [1mLearn more at:[0m [38;5;14m[4mhttps://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#removed-custom-reporters[0m

[38;5;243mTo silence deprecations that can be silenced set the following environment variable:[0m
  [38;5;243mACK_GINKGO_DEPRECATIONS=1.16.5[0m

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

mkumatag avatar Jul 13 '22 06:07 mkumatag

@Amulyam24 @Prajyot-Parab see if anyone of you are interested picking this one.

mkumatag avatar Jul 13 '22 07:07 mkumatag

For reference - https://github.com/kubernetes/kubernetes/pull/109111

mkumatag avatar Jul 13 '22 07:07 mkumatag

CAPI PR: https://github.com/kubernetes-sigs/cluster-api/pull/6906

mkumatag avatar Jul 13 '22 07:07 mkumatag

I'll work on it 👍🏼 /assign

Amulyam24 avatar Jul 13 '22 07:07 Amulyam24

  • The CAPI project has decided to hold off the bump to Ginkgo v2 till the release 1.3.0(ref- PR above and https://kubernetes.slack.com/archives/C8TSNPY4T/p1657801887174059). Dependency- The provider E2E test framework is based on the CAPI E2E framework.
  • Another dependency is the controller-runtime module that depends on ginkgo v1 and leads to indirect importing of it which could cause conflict in handling the flags

Amulyam24 avatar Jul 19 '22 13:07 Amulyam24

@Amulyam24 are we good to close this one?

Prajyot-Parab avatar Nov 22 '22 06:11 Prajyot-Parab

Yes, this can be closed. /close

Amulyam24 avatar Nov 22 '22 09:11 Amulyam24

@Amulyam24: Closing this issue.

In response to this:

Yes, this can be closed. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 22 '22 09:11 k8s-ci-robot