cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

VPC: Add Custom Image reconciliation

Open cjschaef opened this issue 1 year ago • 5 comments

Add support to reconcile a VPC Custom Image for the new v2 VPC Infrastructure reconcile logic.

Related: https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1896

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add support to reconcile VPC Custom Images during Infrastructure creation.

cjschaef avatar Sep 04 '24 21:09 cjschaef

Hi @cjschaef. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 04 '24 21:09 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 141d72f2c6694e98893dd5914293bdeba7329a52
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66e47e5978b3b500082b7ec5
Deploy Preview https://deploy-preview-1942--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 04 '24 21:09 netlify[bot]

/ok-to-test

mkumatag avatar Sep 06 '24 06:09 mkumatag

LGTM!

dharaneeshvrd avatar Sep 16 '24 04:09 dharaneeshvrd

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjschaef, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 17 '24 04:09 k8s-ci-robot