cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

UT update for powervs machine

Open GunaKKIBM opened this issue 1 year ago • 6 comments

What this PR does / why we need it: Code coverage increase

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes. No change in any image version or functionality

GunaKKIBM avatar Aug 22 '24 05:08 GunaKKIBM

Welcome @GunaKKIBM!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 22 '24 05:08 k8s-ci-robot

Hi @GunaKKIBM. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 22 '24 05:08 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 46c8ff1e97f56bac6754f79271152781841d3d33
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6735945f636ba00008097654
Deploy Preview https://deploy-preview-1927--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 22 '24 05:08 netlify[bot]

/ok-to-test

Karthik-K-N avatar Aug 22 '24 05:08 Karthik-K-N

@GunaKKIBM Please squash the commits.

Prajyot-Parab avatar Oct 18 '24 12:10 Prajyot-Parab

@Karthik-K-N @Amulyam24 @Prajyot-Parab I have addressed the comments, and updated test case names, PTAL.

GunaKKIBM avatar Nov 07 '24 06:11 GunaKKIBM

@GunaKKIBM, it would be great if you could please squash the commits.

Amulyam24 avatar Nov 09 '24 05:11 Amulyam24

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GunaKKIBM, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 14 '24 06:11 k8s-ci-robot