cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

Refactor infra creation to improve the overall infra setup time

Open dharaneeshvrd opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1837

Special notes for your reviewer:

With the changes, infra creation takes around ~8 mins. Most time taking resource is DHCP server VM.

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


dharaneeshvrd avatar Jul 03 '24 04:07 dharaneeshvrd

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit fe3834537733baf4390be7096d8adfceca89c9a5
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66c8229d701b310008c1b317
Deploy Preview https://deploy-preview-1869--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 03 '24 04:07 netlify[bot]

@Karthik-K-N

Whats the time difference between old vs new approach?

Currently it's taking around 15 mins and with these changes it is taking around 8 to 9 mins.

dharaneeshvrd avatar Jul 22 '24 05:07 dharaneeshvrd

@dharaneeshvrd as per the discussion, lets get the early testing done with this PR to ensure it is working fine

mkumatag avatar Aug 06 '24 04:08 mkumatag

@dharaneeshvrd as per the discussion, lets get the early testing done with this PR to ensure it is working fine

Any update on this?

/cc @Karthik-K-N

please take a look and give lgtm if no more comments

mkumatag avatar Aug 16 '24 11:08 mkumatag

@mkumatag

Any update on this?

I have tested personally and Ashwin Hendre also able to test this and reported the improvement of 12% overall cluster setup time.

dharaneeshvrd avatar Aug 16 '24 13:08 dharaneeshvrd

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharaneeshvrd, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 28 '24 04:08 k8s-ci-robot