cluster-api-provider-ibmcloud icon indicating copy to clipboard operation
cluster-api-provider-ibmcloud copied to clipboard

Added yamllint config file .yamllint, fixed current linting errors, added install and run yamllint targets.

Open yuanning6 opened this issue 1 year ago • 8 comments

What this PR does / why we need it:

  1. This PR adds a .yamllint config file which has rules to config yamllint to enhance linting for yaml files. The lint will be helpful to avoid issues like https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/commit/7cd7fcc1c0448df9caae393fa63720a874b36c85.

  2. Fixed current yamllint errors.

  3. Added install and run yamllint targerts in Makefile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1497

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


yuanning6 avatar Apr 15 '24 20:04 yuanning6

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuanning6 Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 15 '24 20:04 k8s-ci-robot

Hi @yuanning6. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 15 '24 20:04 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit ec534c5a020a37e9566b72afd6d541b7cbe9f85c
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/661d8e677414bc00088bcaee
Deploy Preview https://deploy-preview-1727--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 15 '24 20:04 netlify[bot]

/ok-to-test

Prajyot-Parab avatar Apr 16 '24 13:04 Prajyot-Parab

Hi @Prajyot-Parab !

Thank you so much for your time to take a look at my code! Please let me know if any adjustment is needed!

yuanning6 avatar Apr 22 '24 17:04 yuanning6

/cc @Karthik-K-N @Amulyam24

Prajyot-Parab avatar Apr 24 '24 07:04 Prajyot-Parab

/cc @Karthik-K-N @Amulyam24

Prajyot-Parab avatar Apr 29 '24 05:04 Prajyot-Parab

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 24 '24 18:05 k8s-ci-robot

Don't see any activities in this PR, @Amulyam24 will pick this PR and review comments and create a new one

mkumatag avatar Aug 06 '24 04:08 mkumatag