cluster-api-provider-ibmcloud
cluster-api-provider-ibmcloud copied to clipboard
Added yamllint config file .yamllint, fixed current linting errors, added install and run yamllint targets.
What this PR does / why we need it:
-
This PR adds a .yamllint config file which has rules to config yamllint to enhance linting for yaml files. The lint will be helpful to avoid issues like https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/commit/7cd7fcc1c0448df9caae393fa63720a874b36c85.
-
Fixed current yamllint errors.
-
Added install and run yamllint targerts in Makefile.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1497
Special notes for your reviewer:
/area provider/ibmcloud
- Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yuanning6 Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @yuanning6. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
| Name | Link |
|---|---|
| Latest commit | ec534c5a020a37e9566b72afd6d541b7cbe9f85c |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/661d8e677414bc00088bcaee |
| Deploy Preview | https://deploy-preview-1727--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
Hi @Prajyot-Parab !
Thank you so much for your time to take a look at my code! Please let me know if any adjustment is needed!
/cc @Karthik-K-N @Amulyam24
/cc @Karthik-K-N @Amulyam24
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Don't see any activities in this PR, @Amulyam24 will pick this PR and review comments and create a new one