cluster-api-provider-ibmcloud
cluster-api-provider-ibmcloud copied to clipboard
kubernetes-sigs
VPC: Create basic types for VPC
Create a basic VPC resource type that VPC definitions will use.
What this PR does / why we need it: VPC updates will need references to generic VPC resources. This could be shared with PowerVS, if they wish to adopt them.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # N/A
Special notes for your reviewer: Replaces https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1668
/area provider/ibmcloud
- Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
Hi @cjschaef. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
| Name | Link |
|---|---|
| Latest commit | dc4e22355a4652a0f34a19d2b4d62e6753f16bc4 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/660dc42d54c9c000082eab2f |
| Deploy Preview | https://deploy-preview-1670--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cjschaef Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@cjschaef I think we are mixing 2 things here - COS bucket for the image import and the ignition data. I recommend you @Karthik-K-N @Prajyot-Parab and @cjschaef please setup a meeting offline to discuss on the spec considering the amount of time we are left with for the implementation.
Sure, We can do this if there are still confusions on the workflow.
@mkumatag @Karthik-K-N Based on the findings I've had, reviewing the PowerVS code, expectations, and dependencies, my expectations for the VPC path, is not to rely on CAPI controllers to create COS resources (COS Instance, Bucket, or Object).
~Instead, I plan to rely on the COS Instance ID, the Bucket Name, and likely the COS Object Name, with the alternative being I can rely on the Object URL instead, but that depends on IBM Cloud VPC API's, which I have to re-review.~
~If PowerVS does not wish or plan to share this common COS Instance type, I will not add any additional fields to accommodate PowerVS (e.g., COS Instance Name).~
Based on my discoveries, I have decided to drop COS altogether for VPC related support. References to any necessary COS resources will be handled as needed, using ObjectURL's, and not referencing Instances, Buckets, etc.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.