cluster-api-provider-ibmcloud
cluster-api-provider-ibmcloud copied to clipboard
VPC: Add infrastructure creation proposal
Add a new proposal with details and images for creating and deleting VPC resources for the IBMVPCCluster definition.
What this PR does / why we need it: Adds a new proposal to extend VPC Cluster support to create necessary resources based on design.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # N/A
Special notes for your reviewer: We expect to break up our enhancements into the following sets:
- API updates - likely break down into multiple smaller PR's
- Implement missing/new creation/reconcile logic for new resources
- Implement deletion/cleanup of resources as necessary.
/area provider/ibmcloud
- Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cjschaef Once this PR has been reviewed and has the lgtm label, please assign jichenjc for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @cjschaef. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
| Name | Link |
|---|---|
| Latest commit | cd20ff1524483ae1d27a936e7639b953ecbca052 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/65f37b768c606f000818512a |
| Deploy Preview | https://deploy-preview-1657--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/cc @Karthik-K-N
@cjschaef as discussed in our last sync up - please start working on the controller part, we can keep this item and not blocking you to implement the controller and merge
/easycla /ok-to-test
@cjschaef please update this PR, we are planning to merge soon