cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

docs: Add section about Machine Location

Open evanfreed opened this issue 2 years ago • 3 comments

What this PR does / why we need it:

Adds section to docs about machine location.

Kudos to @itspngu -- This reattempts to merge https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/455.

I unfortunately couldn't cherry-pick it as the original repo is deleted, but think this information is still highly relevant and important to people who are getting started with CAPG.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Related to #444

Special notes for your reviewer:

TODOs:

  • [ ] squashed commits
  • [x] includes documentation
  • [ ] adds unit tests

Release note:

NONE

Signed-off-by: Evan Freed [email protected]

/kind documentation

evanfreed avatar Aug 12 '22 20:08 evanfreed

Hi @evanfreed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 12 '22 20:08 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: evanfreed Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval by writing /assign @neolit123 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 12 '22 20:08 k8s-ci-robot

/ok-to-test /assign @pydctw

cpanato avatar Aug 18 '22 08:08 cpanato

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 16 '22 09:11 k8s-triage-robot

/remove-lifecycle stale

evanfreed avatar Nov 16 '22 16:11 evanfreed

/lgtm

richardcase avatar Dec 14 '22 13:12 richardcase

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, evanfreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Dec 14 '22 13:12 k8s-ci-robot