use kustomize installed from makefile and remove unused install script

[sayantani11]

What type of PR is this?

What this PR does / why we need it: This PR aligns the CI and install shell scripts in the repo to use kustomize binary installed in hack/tools/bin/ directory. Shell scripts also check/installs missing kustomize tools in hack/tools/bin/ dir, via Makefile recipes, before using it in the shell script.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #491

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [ ] squashed commits
• [ ] includes documentation
• [ ] adds unit tests

Release note:

use kustomize installed from makefile and remove unused install script

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayantani11 Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sayantani11]

@cpanato Can you please help with the error? I am still not able to get through what I am missing.

[evanfreed]

@sayantani11 I think you might need something like this in your makefile. Its a bit confusing

.PHONY: $(KUSTOMIZE_BIN)
$(KUSTOMIZE_BIN): $(KUSTOMIZE) ## Building Kustomize from tools folder

OR 

kustomize: $(KUSTOMIZE) ## Build a local copy of kustomize.

The first one mimics what other targets in the GCP Makefile follow.

[sayantani11]

@evanfreed I actually was thinking the same thing. But I wasn't sure if I should, but will give it a try.

On Sat, 13 Aug 2022 at 00:38, evanfreed @.***> wrote:

@sayantani11 https://github.com/sayantani11 I think you might need something like this in your makefile. Its a bit confusing

.PHONY: $(KUSTOMIZE_BIN) $(KUSTOMIZE_BIN): $(KUSTOMIZE) ## Building Kustomize from tools folder

OR

kustomize: $(KUSTOMIZE) ## Build a local copy of kustomize.

The first one mimics what other targets in the GCP Makefile follow.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/669#issuecomment-1213432021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7Q7RSLES54JSWG7HHZOMLVY2OKJANCNFSM54WWPS2Q . You are receiving this because you were mentioned.Message ID: @.***>

[sayantani11]

@cpanato I am not able to understand the test-e2e error, although I tried fixing it but I am not able to understand why the error is still there.

[k8s-ci-robot]

@sayantani11: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-gcp-e2e-test	bcc8c2a14ae5c052c02d1cfb128b08b514403c57	link	true	/test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sayantani11]

cc @cpanato

[cpanato]

you might need to rebase to catch new things from the main branch

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.