cluster-api-provider-gcp
cluster-api-provider-gcp copied to clipboard
kubernetes-sigs
feat: Add support for feature gates
What type of PR is this?
What this PR does / why we need it: Adds the ability to use feature gates.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #643
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
- [x] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
Adding features via feature gate
/feature
Signed-off-by: Evan Freed [email protected]
Hi @evanfreed. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@evanfreed Please run make modules and make verify-modules and try pushing the PR again.
Sorry for the delay, I had some time off so I didn't look at this. I repushed after running make modulesand make verify-modules. Looks like there was an update to the go mod file, must have snuck in with a different commit but should be fixed up 🤞
Hi! I'm working on a PR where I would love to feature gate support -- is there anything I can do to help this PR get merged?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: evanfreed
Once this PR has been reviewed and has the lgtm label, please assign dims for approval by writing /assign @dims in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@eaceaser sorry for the delay in response, I was on vacation for a bit. I think we're good here now that I rebased, I'm just waiting for a review.
@sayantani11 @fabriziopandini or @sbueringer would you be willing to take a look? 🙏 thanks in advanced
/cc @cpanato
@evanfreed Fabrizio and I are mostly in the reviewer list because maintainers of core CAPI were synced into the OWNERS file of CAPG.
@cpanato when you get a chance could you look this over? I've been trying to get this one finished up for a while.
@pydctw is there a chance you'd be able to look at this? I'm struggling to find a reviewer.
@pydctw: GitHub didn't allow me to assign the following users: for, approval.
Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @cpanato for approval
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, evanfreed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cpanato]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment