cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Making GCPManagedCluster.Network a required field

Open tasdikrahman opened this issue 7 months ago • 3 comments

/kind bug

What steps did you take and what happened:

As noted in this issue https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/1187 here, the Network field is a required field implicitly, as during the reconcile process of GCPManagedCluster, requires the presence of this field.

What we could potentially do here based on this discussion https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1259#issuecomment-2167480985 is to make it a required field either in v1beta1 or v1beta2

What did you expect to happen: GCPManagedCluster.Network becomes a required field.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

reference PR which fixes the controller crashing. https://github.com/kubernetes-sigs/cluster-api-provider-gcp/pull/1259

Environment:

  • Cluster-api version:
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

tasdikrahman avatar Jul 08 '24 14:07 tasdikrahman