cluster-api-provider-gcp icon indicating copy to clipboard operation
cluster-api-provider-gcp copied to clipboard

Support additional GCPManagedControlPlane fields

Open akshay196-rafay opened this issue 11 months ago • 5 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add following GCPManagedControlPlane fields:

  • Description
  • Cluster Network
    • PrivateCluster
    • UseIPAliases
    • Pod
    • Service
  • Cluster Security
    • WorkloadIdentityConfig
    • AuthenticatorGroupConfig
    • EnableLagacyAuthorization
    • IssueClientCertificate
  • AddonsConfig
  • LoggingConfig
  • MonitoringConfig

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #906

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

TBD

akshay196-rafay avatar Mar 20 '24 07:03 akshay196-rafay

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akshay196-rafay Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 20 '24 07:03 k8s-ci-robot

Hi @akshay196-rafay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 20 '24 07:03 k8s-ci-robot

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
Latest commit 5849651a8dedc8980a5cc70c6383826bc4db97bf
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/660a89d3f754f8000867d4cb
Deploy Preview https://deploy-preview-1186--kubernetes-sigs-cluster-api-gcp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 20 '24 07:03 netlify[bot]

/ok-to-test /test all

cpanato avatar Mar 20 '24 07:03 cpanato

@akshay196-rafay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-apidiff f5e6b5b767e79b3c5a8bf0854eb3b603f2231ab5 link false /test pull-cluster-api-provider-gcp-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Mar 20 '24 07:03 k8s-ci-robot

@akshay196-rafay - would you be able to look at the lint issues?

richardcase avatar Mar 27 '24 08:03 richardcase