cluster-api-provider-cloudstack icon indicating copy to clipboard operation
cluster-api-provider-cloudstack copied to clipboard

Update docs for VPC integration

Open vishesh92 opened this issue 8 months ago • 3 comments

Issue #, if available:

Description of changes:

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

vishesh92 avatar Mar 26 '25 18:03 vishesh92

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
Latest commit 7cda6728e4ff4a493705da338d69739f8cfa510a
Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-cloudstack/deploys/682afcde819265000820c31b
Deploy Preview https://deploy-preview-434--kubernetes-sigs-cluster-api-cloudstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Mar 26 '25 18:03 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.78%. Comparing base (d597e80) to head (7cda672). Report is 102 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   25.66%   25.78%   +0.11%     
==========================================
  Files          59       72      +13     
  Lines        5563     6778    +1215     
==========================================
+ Hits         1428     1748     +320     
- Misses       3996     4865     +869     
- Partials      139      165      +26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 26 '25 18:03 codecov-commenter

@kiranchavala I have updated the docs a little bit. As of now, for using the flavor with-existing-vpc-network requires an extra environment variable for the VPC name. The default & with-kube-vip flavor requires the same environment variables to be defined.

vishesh92 avatar May 01 '25 05:05 vishesh92

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kiranchavala, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 19 '25 09:05 k8s-ci-robot

/lgtm

weizhouapache avatar May 19 '25 10:05 weizhouapache