cluster-api-provider-cloudstack icon indicating copy to clipboard operation
cluster-api-provider-cloudstack copied to clipboard

Update ttlcache library to v3, disable TTL extension on hit

Open hrak opened this issue 1 year ago • 4 comments

Issue #, if available:

Fixes #336

Description of changes:

This PR gives the ttlcache library a major update and disables TTL extension on cache item hit.

Testing performed:

make test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hrak avatar Jan 17 '24 14:01 hrak

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
Latest commit 2f1182c87fecbcde5f45f2c63499b5f93d024ee5
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/664f201447ef5f00087397c5
Deploy Preview https://deploy-preview-338--kubernetes-sigs-cluster-api-cloudstack.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 17 '24 14:01 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (207f0a2) 25.45% compared to head (781dee8) 25.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   25.45%   25.52%   +0.06%     
==========================================
  Files          59       59              
  Lines        5555     5560       +5     
==========================================
+ Hits         1414     1419       +5     
  Misses       4002     4002              
  Partials      139      139              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 17 '24 14:01 codecov-commenter

Thanks for the PR @hrak! A bit caught up right now but I will get to it :)

g-gaston avatar Jan 23 '24 14:01 g-gaston

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 12 '24 16:05 k8s-triage-robot

@hrak some minor code changes required.

vishesh92 avatar May 20 '24 09:05 vishesh92

/ok-to-test

vishesh92 avatar May 20 '24 09:05 vishesh92

/remove-lifecycle stale

g-gaston avatar May 20 '24 16:05 g-gaston

/retest

rohityadavcloud avatar May 23 '24 12:05 rohityadavcloud

Test Results : (tid-427) Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8 Kubernetes Version: v1.27.2 Kubernetes Version upgrade from: v1.26.5 Kubernetes Version upgrade to: v1.27.2 CloudStack Version: 4.19 Template: ubuntu-2004-kube E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr338-sl-427.zip



Summarizing 1 Failure:
  [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
  /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinedeployment_helpers.go:127

Ran 28 of 29 Specs in 10734.848 seconds
FAIL! -- 27 Passed | 1 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (10734.85s)
FAIL

blueorangutan avatar May 23 '24 15:05 blueorangutan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrak, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 23 '24 15:05 k8s-ci-robot

/lgtm

vishesh92 avatar May 23 '24 19:05 vishesh92