Update ttlcache library to v3, disable TTL extension on hit
Issue #, if available:
Fixes #336
Description of changes:
This PR gives the ttlcache library a major update and disables TTL extension on cache item hit.
Testing performed:
make test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
| Name | Link |
|---|---|
| Latest commit | 2f1182c87fecbcde5f45f2c63499b5f93d024ee5 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/664f201447ef5f00087397c5 |
| Deploy Preview | https://deploy-preview-338--kubernetes-sigs-cluster-api-cloudstack.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
207f0a2) 25.45% compared to head (781dee8) 25.52%.
Additional details and impacted files
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 25.45% 25.52% +0.06%
==========================================
Files 59 59
Lines 5555 5560 +5
==========================================
+ Hits 1414 1419 +5
Misses 4002 4002
Partials 139 139
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the PR @hrak! A bit caught up right now but I will get to it :)
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
@hrak some minor code changes required.
/ok-to-test
/remove-lifecycle stale
/retest
Test Results : (tid-427) Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8 Kubernetes Version: v1.27.2 Kubernetes Version upgrade from: v1.26.5 Kubernetes Version upgrade to: v1.27.2 CloudStack Version: 4.19 Template: ubuntu-2004-kube E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr338-sl-427.zip
Summarizing 1 Failure:
[FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
/root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinedeployment_helpers.go:127
Ran 28 of 29 Specs in 10734.848 seconds
FAIL! -- 27 Passed | 1 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (10734.85s)
FAIL
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hrak, vishesh92
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vishesh92]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm