cluster-api-provider-cloudstack
cluster-api-provider-cloudstack copied to clipboard
kubernetes-sigs
Tilt metrics fix + docs update
Issue #, if available:
Description of changes:
This PR fixes an issue of CAPC failing to start with the following error due to double injection of prometheus metrics settings (this is taken care of by tilt-prepare now)
Build Failed: Deployment.apps "capc-controller-manager" is invalid: spec.template.spec.containers[0].ports[2].name: Duplicate value: "metrics"
It also updates the tilt docs to remove old info regarding credentials, and adds an example on how to enable a CAPI feature gate.
Testing performed:
make tilt-up successfully starts CAPC.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Hi @hrak. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
| Name | Link |
|---|---|
| Latest commit | 6009a1ceabc6ee25111277b6d851d282074851a6 |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/656096d4f27aaf0008f83047 |
| Deploy Preview | https://deploy-preview-308--kubernetes-sigs-cluster-api-cloudstack.netlify.app/print |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version:
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
Codecov Report
Patch and project coverage have no change.
Comparison is base (
a2e323a) 25.47% compared to head (6fa985f) 25.47%.
Additional details and impacted files
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 25.47% 25.47%
=======================================
Files 59 59
Lines 5554 5554
=======================================
Hits 1415 1415
Misses 4000 4000
Partials 139 139
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@vishesh92 a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version: 4.18
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hrak, rohityadavcloud, vishesh92
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [rohityadavcloud,vishesh92]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Just pushed a small additional change that allows Tilt and e2e tests to replace the metrics listen address (and removes a hack that made this work in e2e before)
related: https://github.com/kubernetes-sigs/cluster-api/commit/7768a6db2ee986da2458e9c73d4c3c988095a4a7#diff-df1234d6ebfa1846a2bace68630ce653b3402bd4388aa4b0b8fb724df34b4af7
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version: 4.18
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version: 4.18
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version: 4.19
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
@vishesh92 a jenkins job has been kicked to run test with following paramaters:
- kubernetes version: 1.27.2
- CloudStack version: 4.19
- hypervisor: kvm
- template: ubuntu-2004-kube
- Kubernetes upgrade from: 1.26.5 to 1.27.2
Test Results : (tid-485) Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8 Kubernetes Version: v1.27.2 Kubernetes Version upgrade from: v1.26.5 Kubernetes Version upgrade to: v1.27.2 CloudStack Version: 4.19 Template: ubuntu-2004-kube E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr308-sl-485.zip
Summarizing 4 Failures:
[FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
/root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinedeployment_helpers.go:127
[FAIL] When testing project [AfterEach] Should create a cluster in a project
/jenkins/workspace/capc-e2e-new/test/e2e/project.go:103
[FAIL] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
/root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/deployment_helpers.go:88
[TIMEDOUT] When testing with custom disk offering [It] Should successfully create a cluster with a custom disk offering
/jenkins/workspace/capc-e2e-new/test/e2e/custom_disk_offering.go:61
Ran 27 of 30 Specs in 10816.759 seconds
FAIL! - Suite Timeout Elapsed -- 23 Passed | 4 Failed | 0 Pending | 3 Skipped
--- FAIL: TestE2E (10816.76s)
FAIL