ClusterAPI Provider does not translate existing CS network name into Kubernetes safe name

[joschi36]

/kind bug

What steps did you take and what happened: Created a Cluster with an existing Network and the Getting Started Guide. The network name referenced is called "M_Play". Installation failed with the following message. E0718 09:00:43.305057 1 controller.go:317] controller/cloudstackfailuredomain "msg"="Reconciler error" "error"="creating isolated network CRD: CloudStackIsolatedNetwork.infrastructure.cluster.x-k8s.io \"capc-cluster-m_play\" is invalid: metadata.name: Invalid value: \"capc-cluster-m_play\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')" "name"="e146065e3fcde3e28804d45cb6e45297" "namespace"="capi-joschi" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="CloudStackFailureDomain"

What did you expect to happen: I expected that cluster-api-provider-cloudstack translates names from cloudstack to kubernetes. Eg. replaces the underlines with hypens.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api-provider-cloudstack version: 1.4.4
• Kubernetes version: (use kubectl version): 1.24.14
• OS (e.g. from /etc/os-release): rockylinux (prebuilt)

[rohityadavcloud]

Hi @joschi36 is that still an issue, can you try with more recent CAPC releases?

[joschi36]

@rohityadavcloud I still have the same error, but I could only test to version cloudstack:v0.4.9-rc4. Rc6 gave me the following error:

./clusterctl init --infrastructure cloudstack:v0.4.9-rc6       

Fetching providers
Error: failed to get provider components for the "cloudstack:v0.4.9-rc6" provider: failed to read "infrastructure-components.yaml" from provider's repository "infrastructure-cloudstack": failed to download files from GitHub release v0.4.9-rc6: failed to get file "infrastructure-components.yaml" from "v0.4.9-rc6" release

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vishesh92]

/remove-lifecycle stale