cluster-api-provider-azure icon indicating copy to clipboard operation
cluster-api-provider-azure copied to clipboard

WIP: Add MP to ci-version-ipv6 template

Open willie-yao opened this issue 10 months ago • 10 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: This PR adds the missing MachinePools in templates/test/ci/cluster-template-prow-ci-version-ipv6.yaml.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #4393

Special notes for your reviewer:

  • [ ] cherry-pick candidate

TODOs:

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note:

NONE

willie-yao avatar Apr 23 '24 21:04 willie-yao

/test ?

willie-yao avatar Apr 23 '24 21:04 willie-yao

@willie-yao: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-ci-entrypoint
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-aks
  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-apiversion-upgrade
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-conformance
  • /test pull-cluster-api-provider-azure-conformance-custom-builds
  • /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-e2e-optional
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow
  • /test pull-cluster-api-provider-azure-windows-custom-builds
  • /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-conformance
  • pull-cluster-api-provider-azure-conformance-custom-builds
  • pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
  • pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
  • pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-windows-custom-builds
  • pull-cluster-api-provider-azure-windows-with-ci-artifacts

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 23 '24 21:04 k8s-ci-robot

/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

willie-yao avatar Apr 23 '24 21:04 willie-yao

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.00%. Comparing base (91a4b89) to head (37702d1). Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4769      +/-   ##
==========================================
- Coverage   62.02%   62.00%   -0.03%     
==========================================
  Files         201      201              
  Lines       16858    16862       +4     
==========================================
- Hits        10457    10455       -2     
- Misses       5618     5624       +6     
  Partials      783      783              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 23 '24 21:04 codecov[bot]

/retest

willie-yao avatar Apr 24 '24 18:04 willie-yao

Getting this error in the logs. Not sure why the template is using v1.31.0-alpha.0.397+bf6507070cdc04 as the kubernetes version

"Reconciler error" err="failed to init machinepool scope cache: failed to get default OS image: failed to get default image: no VM image found for publisher \"cncf-upstream\" offer \"capi\" sku \"ubuntu-2204-gen1\" with Kubernetes version \"v1.31.0-alpha.0.397+bf6507070cdc04\"" controller="azuremachinepool" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AzureMachinePool" AzureMachinePool="capz-conf-sk4knp/capz-conf-sk4knp-mp-0" namespace="capz-conf-sk4knp" name="capz-conf-sk4knp-mp-0" reconcileID="e14a89fc-4f4a-4539-9d57-df644f70465a"

willie-yao avatar Apr 25 '24 00:04 willie-yao

/retest

willie-yao avatar May 15 '24 22:05 willie-yao

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from willie-yao. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 15 '24 22:05 k8s-ci-robot

@willie-yao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts 37702d1053c3c3802a1f8c40b0d8f98e56eb41ae link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-windows-custom-builds 37702d1053c3c3802a1f8c40b0d8f98e56eb41ae link false /test pull-cluster-api-provider-azure-windows-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar May 15 '24 23:05 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 21 '24 10:05 k8s-ci-robot

/close

Closing for now until I have time to look at it again!

willie-yao avatar Jul 23 '24 16:07 willie-yao

@willie-yao: Closed this PR.

In response to this:

/close

Closing for now until I have time to look at it again!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 23 '24 16:07 k8s-ci-robot