kubernetes-sigs
[WIP] Bump CAPI to v1.7.0-beta.0
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates CAPI to v1.7.0-beta.0 and all that entails.
Which issue(s) this PR fixes:
Fixes #4647
Special notes for your reviewer:
See the migration guide for more information.
- [ ] cherry-pick candidate
TODOs:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
Bump CAPI to v1.7.0-beta.0
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mboersma. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The unit test failure is interesting. I'm not sure how to handle it, so I left it in for advice:
--- FAIL: TestASOSecretReconcile (0.08s)
--- FAIL: TestASOSecretReconcile/should_return_if_cluster_is_paused (0.00s)
asosecret_controller_test.go:324:
Expected
<string>: Normal ClusterPaused or linked Cluster is marked as paused. Won't reconcile
to contain substring
<string>: AzureCluster or linked Cluster is marked as paused. Won't reconcile
I think this comes from the code below. The question is: why did asoSecretOwner.GetObjectKind() return "Normal ClusterPaused "?
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/2df97fdc74e2892fed4c3f300c49f5dfac201bd1/controllers/asosecret_controller.go#L227-L232
Edit: the reason is that asoSecretOwner.GetObjectKind() whose TypeMeta is empty, so the event has spaces before and after what should have been "AzureCluster".
See kubernetes-sigs/cluster-api#10331 and kubernetes-sigs/controller-runtime#2633
The unit test is failing because the TypeMeta of the AzureCluster object is empty. I can't tell if that's a CAPI thing yet...
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.47%. Comparing base (
fdb91f9) to head (069f821). Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4646 +/- ##
=======================================
Coverage 62.47% 62.47%
=======================================
Files 195 195
Lines 15624 15624
=======================================
Hits 9761 9761
Misses 5178 5178
Partials 685 685
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
The e2e tests are failing when trying to do clusterctl init. See kubernetes-sigs/cluster-api#10332.
Edit: I'd forgotten to add a 1.7 stanza to the test metadata file apparently. 🤦🏻
/test pull-cluster-api-provider-azure-conformance /test pull-cluster-api-provider-azure-e2e-workload-upgrade /test pull-cluster-api-provider-azure-windows-custom-builds
@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-cluster-api-provider-azure-e2e-workload-upgrade | 8502354e26c5ac36b8e950f0da7e95e7f9da661d | link | false | /test pull-cluster-api-provider-azure-e2e-workload-upgrade |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@mboersma: Closed this PR.
In response to this:
/close
See #4740
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.