cluster-api-provider-azure
cluster-api-provider-azure copied to clipboard
kubernetes-sigs
test: surround CAAPH values strings in quotes
What type of PR is this?
/kind flake
What this PR does / why we need it:
This PR ensures that HelmChartProxy values strings are strings where there could be some ambiguity.
Addresses https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/175
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
- [ ] cherry-pick candidate
TODOs:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
Release note:
NONE
@jackfrancis: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.
In response to this:
/cherry-pick release-1.13
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.73%. Comparing base (
ad6d0d9) to head (0a60b8c). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4593 +/- ##
=======================================
Coverage 62.73% 62.73%
=======================================
Files 192 192
Lines 15641 15641
=======================================
Hits 9812 9812
Misses 5146 5146
Partials 683 683
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
/lgtm Could approvers help review this one? Cloudprovider tests met the issue again.
LGTM label has been added.
@nawazkh @Jont828 I changed this one up a bit and it looks like it's passing. I think this may solve @lzhecheng's issues w/ short git shas sometimes getting interpreted as number types (when the SHA doesn't include an alpha character in it).
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nojnhuh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [nojnhuh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jackfrancis: #4593 failed to apply on top of branch "release-1.13":
Applying: test: surround CAAPH values strings in quotes
Using index info to reconstruct a base tree...
A templates/test/ci/cluster-template-prow-spot.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/cluster-template-windows.yaml
CONFLICT (content): Merge conflict in templates/cluster-template-windows.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: surround CAAPH values strings in quotes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick release-1.13
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@mboersma: new pull request created: #4661
In response to this:
/cherrypick release-1.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jackfrancis: cannot checkout release-1.15: error checking out "release-1.15": exit status 1 error: pathspec 'release-1.15' did not match any file(s) known to git
In response to this:
/cherry-pick release-1.15
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.