kubernetes-sigs
Add race detector toggle for Tilt binaries
/kind feature
Describe the solution you'd like
From Go's documentation for the data race detector:
...you may find more races by running a binary built with -race under a realistic workload.
Let's add a RACE_DETECTOR option for Tilt to build binaries with the -race flag. This option may help us to find previously undetected bugs that will undoubtedly arise in production environments otherwise.
Anything else you would like to add:
To work on this issue, you should have a local development environment with tilt set up as described in CAPZ's developer documentation.
Implementing this begins with the Tiltfile in the root of the project, where you can identify each place we go build a binary. Add an option that will be read from your local tilt-settings.json, and amend each go build to include the -race flag if the option is enabled. (Or something like that. 😄)
Please ask for help here on this GitHub issue or in the cluster-api-azure Slack channel.
See also #2646
@mboersma: This request has been marked as suitable for new contributors.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/help /good-first-issue /priority backlog
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
