cluster-api-provider-azure icon indicating copy to clipboard operation
cluster-api-provider-azure copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Simplify and reuse variables in hack/tools/*.sh scripts

Open nawazkh opened this issue 2 years ago • 4 comments

/kind feature

Describe the solution you'd like [A clear and concise description of what you want to happen.]

  • There are a bunch of variables (like KUBECTL, kustomize) defined multiple times in the shell scripts of hack/tools/**.sh which can be pulled out to a shell script (for ex: common_vars.sh).
  • This new shell script (for ex, common_vars.sh) can then be referenced in the hack/tools/*.sh scripts.
  • This effort would simplify and reuse code in hack/tools/*.sh scripts.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

  • n/a

Environment:

  • cluster-api-provider-azure version: n/a
  • Kubernetes version: (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): n/a

nawazkh avatar Jul 22 '22 15:07 nawazkh

/good-first-issue /help

nawazkh avatar Jul 22 '22 15:07 nawazkh

@nawazkh: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 22 '22 15:07 k8s-ci-robot

/assign

lakshkeswani avatar Jul 23 '22 02:07 lakshkeswani

@lakshkeswani kudos on picking up the issue! Feel free to ping us on cluster-api-azure slack channel or in the git issue itself in case you need help!

nawazkh avatar Jul 25 '22 13:07 nawazkh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 23 '22 14:10 k8s-triage-robot

/remove-lifecycle stale

nawazkh avatar Oct 24 '22 17:10 nawazkh

/close

nawazkh avatar Dec 14 '22 00:12 nawazkh

@nawazkh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 14 '22 00:12 k8s-ci-robot