add ability to specify custom DNS settings for a VM in the cluster

[nawazkh]

What type of PR is this? /kind feature

What this PR does / why we need it:

• A user would be able to specify a custom DNS setting for a VM in the cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2182

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• [x] squashed commits
• [ ] includes documentation
• [x] adds unit tests

Release note:

AzureMachineSpec has been updated with DNSServers field. Users get to specify custom DNS Settings for a VM in the cluster.

[k8s-ci-robot]

Hi @nawazkh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invidian]

/ok-to-test

[mboersma]

/milestone v1.5

[nawazkh]

/retitle [WIP] NIC specific DNS settings

[k8s-ci-robot]

@nawazkh: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle [WIP] NIC specific DNS settings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nawazkh]

I see the same error as above listed pull-cluster-api-provider-azure-apidiff on running make apidiff locally

sigs.k8s.io/cluster-api-provider-azure/azure/services/networkinterfaces
  Incompatible changes:
  - NICSpec: old is comparable, new is not
  Compatible changes:
  - NICSpec.DNSServers: added

sigs.k8s.io/cluster-api-provider-azure/azure/scope
  Incompatible changes:
  - (*MachineScope).InboundNatSpecs: changed from func(map[int32]struct{}) []sigs.k8s.io/cluster-api-provider-azure/azure.ResourceSpecGetter to func() []sigs.k8s.io/cluster-api-provider-azure/azure.ResourceSpecGetter
  .
.
.

Is there something else I should be taking care of since I am adding a new field(DNSServers) to the NICSpec here ?

[jsturtevant]

I believe pull-cluster-api-provider-azure-apidiff isn't a required test and is expected to fail in this case. It's a signal for the maintainers that this PR is changing the API. I think you are all set for that test👌

[nawazkh]

/retest-required

[nawazkh]

/retest

[CecileRobertMichon]

@nawazkh can you please rebase and address the merge conflict when you get a chance?

[nawazkh]

Fixed merge conflicts and updated the PR @CecileRobertMichon @mboersma. Please take a look when you have a chance

[nawazkh]

/retest

[nawazkh]

Fixed merge conflicts and updated the PR @CecileRobertMichon @mboersma. Please take a look when you have a chance

PR tests are failing because I havent updated the spec_test for the new fields added in NICSpec Please hold off the review for now.

/hold

[nawazkh]

/hold cancel Sorry I overlooked the hold tag.

[CecileRobertMichon]

/lgtm /approve

🎉

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment