APIServerLB DNS name resolution causes deploy failure on air-gapped systems

[r4f4]

/kind bug

What steps did you take and what happened: After CAPA creates the APIServer Load Balancer and it gets a DNS name, CAPA waits for the DNS name to resolve before continuing the installation [1][2]. I think this check was never reconsidered when support for a secondary LB was added.

Now consider the scenario where a cluster is deployed on an air-gapped system. Trying to resolve the LB DNS name will never succeed .

[1] https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/1641 [2] https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1651

What did you expect to happen: Only check for DNS name resolution when the APIServer LB is public.

Anything else you would like to add: Air-gapped installations are a requirement in C2S/SC2S secret regions.

Environment:

• Cluster-api-provider-aws version: master
• Kubernetes version: (use kubectl version): 1.29
• OS (e.g. from /etc/os-release):

[k8s-ci-robot]

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[r4f4]

See https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4976#issuecomment-2182359526