cluster-api-provider-aws icon indicating copy to clipboard operation
cluster-api-provider-aws copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Support custom CIDRs for port 6443 via ControlPlaneLoadBalancer.IngressRules

Open snehala27 opened this issue 1 year ago • 14 comments

What type of PR is this? /kind bug

What this PR does / why we need it:

On adding custom ingress rules for port 6443 or any other port which is already present in the rule(like port 22 when bastion is enabled), the ingress rules comparison and addition used to fail saying InvalidParameterValue: The same permission must not appear multiple times This PR fixes the following to support addition of new CIDR's for already existing ports:

  1. Remove duplicates while generating getSecurityGroupIngressRules for SecurityGroupControlPlane
  2. Club rules with same protocol and port range while converting ingressRulesToSDKType

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #4470

Special notes for your reviewer:

Checklist:

  • [ ] squashed commits
  • [ ] includes documentation
  • [x] adds unit tests
  • [ ] adds or updates e2e tests

Release note:

snehala27 avatar Sep 04 '23 10:09 snehala27