Update the release changelog script to use arguments

[richardcase]

/kind refactor /priority backlog /triage accepted /help /good-first-issue

Describe the solution you'd like Update the releasechangelog.sh script to use arguments instead of relying on the right variables being set out side the script.

We need to ensure that any variable set from the arguments are local to the script and there is no interference from the variables set in the makefile.

The Makefile will also need to be updated to specify the arguments.

Anything else you would like to add:

This is a follow up from #3388

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[k8s-ci-robot]

@richardcase: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/kind refactor /priority backlog /triage accepted /help /good-first-issue

Describe the solution you'd like Update the releasechangelog.sh script to use arguments instead of relying on the right variables being set out side the script.

We need to ensure that any variable set from the arguments are local to the script and there is no interference from the variables set in the makefile.

The Makefile will also need to be updated to specify the arguments.

Anything else you would like to add:

This is a follow up from #3388

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[meghanajangi]

/assign

[rvacaru]

/assign

[meghanajangi]

/unassign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Skarlso]

@rvacaru Hi. :)

Are you still looking into the regression thing? It's fine if there is just life and delays, that's understandable. Just reaching out for information. :)

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[rvacaru]

@Skarlso I fixed the regression issue on the variables being overridden by the Makefile, the PR is ready to be reviewed and maybe more testing is needed, I tested as much as I could but I'd need some help, see https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3440#issuecomment-1354573179

[Skarlso]

Cool. I'll take a look when I can.

[Skarlso]

/assign