cluster-api-provider-aws
cluster-api-provider-aws copied to clipboard
kubernetes-sigs
AWSManagedMachinePool - Launch Template support
What type of PR is this? /kind feature
What this PR does / why we need it:
Add launch template support to AWSManagedMachinePool.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2055
Special notes for your reviewer:
Checklist:
- [ ] squashed commits
- [ ] includes documentation
- [ ] adds unit tests
- [ ] adds or updates e2e tests
Release note:
Add launch template support to `AWSManagedMachinePool`.
@richardchen331: This issue is currently awaiting triage.
If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @richardchen331. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@richardchen331 @richardcase is this implementation in line with https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/3024?
@richardchen331 @richardcase is this implementation in line with #3024?
@sedefsavas - i need to update the proposal based on a chat that i had with @richardchen331. We decided on a way forward to unblock development. If after the proposal has been updated and changes are needed we can go back and refactor. I will check the proposal updated by EOD Wednesday.
Given that this is an important feature and changes the way we interact with AWSManagedMachinePool, we would want to have this in e2e tests and there is already a proposal out but would be good to update existing docs.
Given that this is an important feature and changes the way we interact with
AWSManagedMachinePool, we would want to have this in e2e tests and there is already a proposal out but would be good to update existing docs.
Agree on adding this to the e2e tests for eks. This is covered in the updated proposal. @richardchen331 i can guide you through this if you want?
Given that this is an important feature and changes the way we interact with
AWSManagedMachinePool, we would want to have this in e2e tests and there is already a proposal out but would be good to update existing docs.Agree on adding this to the e2e tests for eks. This is covered in the updated proposal. @richardchen331 i can guide you through this if you want?
@richardcase Agree that we should have e2e tests for it. It would be great if you could guide me on how to add e2e tests for eks :)
Agree that we should have e2e tests for it. It would be great if you could guide me on how to add e2e tests for eks :)
I'll ping you in slack and we can arrange a zoom session
I was just reviewing this PR 😀 As you have created a new test flavor, it should be added to files section in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/test/e2e/data/e2e_eks_conf.yaml#L179-L207.
I was just reviewing this PR 😀 As you have created a new test flavor, it should be added to files section in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/test/e2e/data/e2e_eks_conf.yaml#L179-L207.
@pydctw Thank you! Just updated the conf and i'll retry the test again :)
Hi @richardcase @sedefsavas , I added e2e test for this change. Could you help review it again? Thanks!