Customresource `spec.deployment` is only a limited subset

[johanjk]

When setting overrides on the deployment, only the following parameters are available:

spec:
  deployment: 
    affinity: [...]
    containers: [...]
    imagePullSecret: [...]
    nodeSelector: [...]
    replicas: [...]
    serviceAccountName: [...]
    tolerations: [...]

I would like to be able to configure, amongst other things spec.strategy. Could the operator allow the full deployment spec to be configured?

/kind feature

[alexander-demicev]

/triage accepted

[alexander-demicev]

This can be added to our deployment spec in provider's API

[salasberryfin]

Hey @johanjk @alexander-demicev. I've been taking a look at this and, assuming the fields of interest are the ones in DeploymentSpec here, there are a few of them that are not optional. Is it expected to support overriding only a selection of these fields or would it be useful to have this struct embedded inline and have access to all fields considering some of them would be required?

[alexander-demicev]

@salasberryfin We had a bad experience with embedding structures in API, if something changes in the structure our API can get broken

[Danil-Grigorev]

Hey @johanjk you can use manifest patch to apply things which are not supported by default spec: https://cluster-api-operator.sigs.k8s.io/03_topics/02_configuration/04_patching-provider-manifests

[furkatgofurov7]

Hey @johanjk you can use manifest patch to apply things which are not supported by default spec

Based on ^, closing this.