cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

fix: fix error evaluation in azure_controller_vmssflex.AttachDisk

Open sunpa93 opened this issue 6 months ago • 6 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: fix error evaluation in azure_controller_vmssflex.AttachDisk

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: fix error evaluation in azure_controller_vmssflex.AttachDisk

sunpa93 avatar May 09 '25 18:05 sunpa93

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 10 '25 00:05 k8s-ci-robot

/retest

andyzhangx avatar May 10 '25 04:05 andyzhangx

/retest

andyzhangx avatar May 10 '25 11:05 andyzhangx

/retest

andyzhangx avatar May 12 '25 02:05 andyzhangx

/retest

MartinForReal avatar May 13 '25 06:05 MartinForReal

/retest

andyzhangx avatar Jul 01 '25 15:07 andyzhangx

/cherrypick release-1.33

andyzhangx avatar Jul 02 '25 02:07 andyzhangx

/cherrypick release-1.32

andyzhangx avatar Jul 02 '25 02:07 andyzhangx

/cherrypick release-1.31

andyzhangx avatar Jul 02 '25 02:07 andyzhangx

@andyzhangx: new pull request created: #9231

In response to this:

/cherrypick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx: #9040 failed to apply on top of branch "release-1.31":

Applying: fix: fix error evaluation in AttachDisk
Using index info to reconstruct a base tree...
M	pkg/provider/azure_controller_vmssflex.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_controller_vmssflex.go
CONFLICT (content): Merge conflict in pkg/provider/azure_controller_vmssflex.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: fix error evaluation in AttachDisk

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyzhangx: new pull request created: #9232

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.