cloud-provider-azure icon indicating copy to clipboard operation
cloud-provider-azure copied to clipboard

Retry deleting the LB if 204 is returned

Open nilo19 opened this issue 1 year ago • 1 comments

What happened:

Deleting LB will sometimes succeed with code 204, but the request doesn't reach NRP side, and the LB doesn't get deleted. We should try to GET the LB to see if it still exists. If so, we should retry deleting it.

What you expected to happen:

The LB should be deleted.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:

nilo19 avatar Aug 12 '22 07:08 nilo19

Hi @nilo19 , I am interested in working on this issue. Would appreciate If you could provide more info and guidance in implementing it.

uroy-personal avatar Sep 05 '22 21:09 uroy-personal

@uroy-personal are you still interested in working on this issue? If not, @nilo19 I'd like to take this work on if it hasn't been addressed already.

amargherio avatar Dec 07 '22 04:12 amargherio

After checking with @nilo19 and a bit of discussion, it appears that this behavior hasn't been observed for a while now. This might be safe to close and could be reopened if the behavior comes up again.

amargherio avatar Jan 17 '23 17:01 amargherio

Thanks for the discussion and conclusion!

/close

feiskyer avatar Jan 19 '23 08:01 feiskyer

@feiskyer: Closing this issue.

In response to this:

Thanks for the discussion and conclusion!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 19 '23 08:01 k8s-ci-robot