cli-utils icon indicating copy to clipboard operation
cli-utils copied to clipboard

Add conversion func for status-policy

Open fsommar opened this issue 5 months ago • 2 comments

Hi 👋

This change is intended for Kpt. We use kpt live apply in our CI/CD pipelines, but we don't need it saving statuses for all resources into the inventory. We want to be able to pass --status-policy=none.

I considered adding support for changing the status-policy flag in kapply as well, but I couldn't think of a way to introduce the flag without introducing it for all subcommands, or copying the description across for the applicable subcommands. Let me know if you want me to implement the flag here too.

fsommar avatar Mar 15 '24 13:03 fsommar

Hi @fsommar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 15 '24 13:03 k8s-ci-robot

/ok-to-test

mortent avatar Apr 15 '24 16:04 mortent

/unassign

ash2k avatar Apr 20 '24 12:04 ash2k

Thanks @fsommar

/approve /lgtm

(Let's see if I have permissions here!)

justinsb avatar Apr 25 '24 11:04 justinsb

/assign seans3

tomasaschan avatar Apr 29 '24 08:04 tomasaschan

/approve

mortent avatar May 04 '24 22:05 mortent

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsommar, justinsb, mortent

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 04 '24 22:05 k8s-ci-robot

Thank you @mortent! Can I get help with creating a tag to be used in https://github.com/kptdev/kpt/pull/4129?

cc @justinsb

fsommar avatar May 07 '24 07:05 fsommar

I'll be doing some other changes for watch filtering soon, so I'll cut a cli-utils release afterwards.

karlkfi avatar May 08 '24 22:05 karlkfi

As for kapply, I think adding a global flag is probably fine, if you add it and tests to exercise it.

karlkfi avatar May 08 '24 22:05 karlkfi

Pending that cli-utils release, will kptdev/kpt#4129 be accepted if it pins cli-utils to the merge commit of this change, even if there is no release that has this change yet?

(We've been blocked on these PRs for over a month, and it doesn't feel like fun to block even more on some other, unrelated, work...)

tomasaschan avatar May 10 '24 18:05 tomasaschan