blixt icon indicating copy to clipboard operation
blixt copied to clipboard

Implement gateway class controller in Rust

Open EandrewJones opened this issue 10 months ago • 2 comments

This PR implements the gateway class controller in Rust.

It does the following:

  • [x] Creates a GatewayClass controller that marks managed GatewayClass resources as accepted
  • [x] Updates the Gateway controller to verify that any GatewayClass is accepted before programming routes
  • [x] Defines HasConditions trait to enable the creation and usage of a generic set_condition util function across both our existing controllers.

To Do:

  • [ ] Add integration tests for GatewayClass and Gateway which mirror our previous Golang-based tests

Closes #300.

EandrewJones avatar Feb 04 '25 06:02 EandrewJones

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EandrewJones Once this PR has been reviewed and has the lgtm label, please assign astoycos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 04 '25 06:02 k8s-ci-robot

@shaneutt @aryan9600 Looking for some light guidance to make sure this is on track before I go ahead with writing the integration tests.

EandrewJones avatar Feb 04 '25 06:02 EandrewJones

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 14 '25 22:05 k8s-triage-robot

Rebased and merged in 61ed8673c1bbbe51028122736a6f0276627ccef1 :+1:

shaneutt avatar Jun 07 '25 15:06 shaneutt