blixt icon indicating copy to clipboard operation
blixt copied to clipboard

Docker build CI needs an update post kubernetes-sigs migration

Open shaneutt opened this issue 2 years ago • 8 comments

Now that we're migrated from https://github.com/kong/blixt to https://github.com/kubernetes-sigs/blixt, some updates need to be made to our container image builds so that we can build and push our images in CI.

shaneutt avatar Oct 11 '23 21:10 shaneutt

https://github.com/kubernetes-sigs/blixt/commit/4e6ec82602b93c2a2efb4bcb0ae8e4a199d7e97d simply disabled the push (but runs the build and everything up to it) as a stop-gap until we move our builds to prow.

shaneutt avatar Oct 26 '23 18:10 shaneutt

cc @ameukam

ameukam avatar Jan 25 '24 14:01 ameukam

GHCR is currently not advised for use since we don't have clarity how repositories exposure. SIG k8s Infra always recommend to use GCP GCR/AR repos for all the subprojects. We have 2 options:

  • setup a dedicated GCR repo
  • use an existing one owned by SIG Network: https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-networking/images.yaml

ameukam avatar Jan 26 '24 10:01 ameukam

Personally I think using an existing one for now is fine, especially if that's easier / more straightforward.

shaneutt avatar Jan 26 '24 14:01 shaneutt

Personally I think using an existing one for now is fine, especially if that's easier / more straightforward.

With k8s-infra hat on, the first option is preferable with isolation of resource at the project and minimize any security issue. I'll try to setup it if we go with this approach.

ameukam avatar Feb 09 '24 19:02 ameukam

I'm in favor. @aryan9600, @astoycos, @mlavacca ?

shaneutt avatar Feb 12 '24 15:02 shaneutt

sounds good to me!

aryan9600 avatar Feb 12 '24 18:02 aryan9600

@ameukam if you're wanting to move forward with that plan, that'll be good 👍

shaneutt avatar Feb 23 '24 01:02 shaneutt