azuredisk-csi-driver icon indicating copy to clipboard operation
azuredisk-csi-driver copied to clipboard

[V2] chore: remove duplicate fields in DriverV2 struct

Open hccheng72 opened this issue 2 years ago • 3 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: Remove duplicate fields that are defined in the DriverCore and DriverV2 with a single config field that points to the AzDiskDriverConfiguration object.

Which issue(s) this PR fixes:

Fixes #1469

Requirements:

Special notes for your reviewer:

Release note:

none

hccheng72 avatar Aug 16 '22 22:08 hccheng72

Hi @hccheng72. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 16 '22 22:08 k8s-ci-robot

/ok-to-test

nearora-msft avatar Aug 16 '22 22:08 nearora-msft

/approve /lgtm

edreed avatar Aug 18 '22 18:08 edreed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, hccheng72

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 18 '22 18:08 k8s-ci-robot