azuredisk-csi-driver
azuredisk-csi-driver copied to clipboard
[V2] chore: remove duplicate fields in DriverV2 struct
What type of PR is this? /kind cleanup
What this PR does / why we need it:
Remove duplicate fields that are defined in the DriverCore
and DriverV2
with a single config field that points to the AzDiskDriverConfiguration
object.
Which issue(s) this PR fixes:
Fixes #1469
Requirements:
- [ ] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Special notes for your reviewer:
Release note:
none
Hi @hccheng72. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: edreed, hccheng72
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [edreed]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment