azuredisk-csi-driver
azuredisk-csi-driver copied to clipboard
kubernetes-sigs
[V2] feat: watch CRD to track driver uninstall
What type of PR is this? /kind feature
What this PR does / why we need it:
- The driver now makes the decision on whether the cloud resource needs to be deleted / detached or not using CRD deletionTimestamp. Which issue(s) this PR fixes:
Fixes #
Requirements:
- [ ] uses conventional commit messages
- [ ] includes documentation
- [ ] adds unit tests
- [ ] tested upgrade from previous version
Special notes for your reviewer:
Release note:
none
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
@sunpa93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-azuredisk-csi-driver-external-e2e-single-az-mainv2 | 761c3437ffedc9bd43f9870e57864c9e4873ac68 | link | true | /test pull-azuredisk-csi-driver-external-e2e-single-az-mainv2 |
| pull-azuredisk-csi-driver-e2e-single-az-mainv2 | 761c3437ffedc9bd43f9870e57864c9e4873ac68 | link | true | /test pull-azuredisk-csi-driver-e2e-single-az-mainv2 |
| pull-azuredisk-csi-driver-e2e-migration-windows-mainv2 | 761c3437ffedc9bd43f9870e57864c9e4873ac68 | link | true | /test pull-azuredisk-csi-driver-e2e-migration-windows-mainv2 |
| pull-azuredisk-csi-driver-e2e-capz-mainv2 | 761c3437ffedc9bd43f9870e57864c9e4873ac68 | link | true | /test pull-azuredisk-csi-driver-e2e-capz-mainv2 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sunpa93
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval by writing /assign @feiskyer in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sunpa93: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
