aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Add non-alphanumeric input validation test for vpcID and fix typo

Open shraddhabang opened this issue 9 months ago • 4 comments

Issue

N/A

Description

  1. As per the request from security team, adding a unit test for malicious input validation for vpcid
  2. Also fixed the typo for certificate arn in IngressClassParam CRD
  3. Added more docs around the Cert arn support for IngressClassParam CRD.
  4. Ran E2E tests locally and verified the change

Checklist

  • [x] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [ ] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

shraddhabang avatar May 09 '24 21:05 shraddhabang

/lgtm

wweiwei-li avatar May 09 '24 21:05 wweiwei-li

@wweiwei-li: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 09 '24 21:05 k8s-ci-robot

/lgtm /approve

oliviassss avatar May 10 '24 17:05 oliviassss

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliviassss, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 10 '24 17:05 k8s-ci-robot