aws-load-balancer-controller
aws-load-balancer-controller copied to clipboard
Add non-alphanumeric input validation test for vpcID and fix typo
Issue
N/A
Description
- As per the request from security team, adding a unit test for malicious input validation for vpcid
- Also fixed the typo for certificate arn in IngressClassParam CRD
- Added more docs around the Cert arn support for IngressClassParam CRD.
- Ran E2E tests locally and verified the change
Checklist
- [x] Added tests that cover your change (if possible)
- [x] Added/modified documentation as required (such as the
README.md
, or thedocs
directory) - [x] Manually tested
- [x] Made sure the title of the PR is a good description that can go into the release notes
BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:
- [ ] Backfilled missing tests for code in same general area :tada:
- [ ] Refactored something and made the world a better place :star2:
/lgtm
@wweiwei-li: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: oliviassss, shraddhabang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [oliviassss]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment