aws-load-balancer-controller
aws-load-balancer-controller copied to clipboard
Helm chart does not allow --load-balancer-class flag to be set
Is your feature request related to a problem?
#2489 added the --load-balancer-class
command line flag to the controller, but as of chart version 1.7.1 there's no ability to configure that flag when deploying via the helm chart.
Describe the solution you'd like
Be able to configure the --load-balancer-class
flag by passing setting .Values.loadBalancerClass
, similar to how the --ingress-class
flag is configured with .Values.ingressClass
.
Describe alternatives you've considered An option to pass custom arguments to the helm chart would be an alternative.
Thank you for your feature request. We will discuss putting this on the roadmap soon! Of course anyone in the community is welcome to contribute as well.
/kind feature
Hi @huangm777, I'd like to take on this as my first contribution to kubernetes. Can this be assigned to me? I'll also appreciate any pointers as to where to start.
Hi @ivange94 -- thanks for your willingness to contribute. A PR was already merged a few days ago for the issue, here (and in the timeline above): https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3647
I will go ahead and mark this issue as closed. Feel free to find another issue to contribute to however! Thanks again.
@ivange94 We have already merged the PR for this issue. You can pick any other good-first-issue which does not have a PR yet and assign it to yourself. We appreciate your interest. Please let us know if you need anything else.
Delivered in v2.8.0