Add support for optionally enforcing NLB security groups on PrivateLi…

[wweiwei-li]

…nk traffic

Issue

https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/3386

Description

This is a feature to support optionally enforce NLB security groups on PrivateLink traffic. For the change, added a new annotation aws-load-balancer-enforce-sg-inbound-private-link-traffic to configure whether NLB security groups should block PrivateLink traffic or not. The value of it can be set to "off" and "on". It is optional and if it is default to "on". After creating new NLB, will check if the annotation is specified. If yes, will call updateSDKLoadBalancerWithSecurityGroups, where added the logic to check if we need to call setSecurityGroup to update EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic.

Checklist

• [ ] Added tests that cover your change (if possible)
• [ ] Added/modified documentation as required (such as the README.md, or the docs directory)
• [x] Manually tested
• [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

• [ ] Backfilled missing tests for code in same general area :tada:
• [ ] Refactored something and made the world a better place :star2:

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: wweiwei-li (bfff95fd5074c86527b79aa5846635b3574510de)

[k8s-ci-robot]

Welcome @wweiwei-li!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @wweiwei-li. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

/check-cla /easycla

[shraddhabang]

/ok-to-test

[oliviassss]

@wweiwei-li, thanks for the contribution. I left some comments.

The value of it can be set to "off" and "on". It is optional and if it is default to "on"

For backward compatibility, I think we shouldn't have "on" as default. If the user doesn't specify the annotation, we skip adding any spec to their NLBs, nothing changed; if the annotation exists, we validate the value and add the spec accordingly.

[shraddhabang]

/lgtm /approve

[oliviassss]

/lgtm /assign @M00nF1sh

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, shraddhabang, wweiwei-li

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [M00nF1sh]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[vumdao]

Hi, can we know when this ticket is released?

[elaineclsouza]

Any predictions on when this will be published in the release?

[VanessaDiniz]

I'm also waiting

[william-araujo-dock]

When will you implement this feature?

[wweiwei-li]

Hey, This feature will be released in V2.8.0 targeting the end of this week.