aws-load-balancer-controller
aws-load-balancer-controller copied to clipboard
Allow webhook failure policies to be configured
Issue
#2711
Description
Allows the end user to set the failurePolicy value to Ignore. This ensures resource creation can proceed when the aws-lb-controller is not functioning or responding within the webhook timeout.
Checklist
- [X] Added tests that cover your change (if possible)
- [X] Added/modified documentation as required (such as the
README.md
, or thedocs
directory) - [X] Manually tested
- [X] Made sure the title of the PR is a good description that can go into the release notes
BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:
- [ ] Backfilled missing tests for code in same general area :tada:
- [ ] Refactored something and made the world a better place :star2:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: josh-ferrell Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@oliviassss or @johngmyers let me know if this PR needs any clarification
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 17.83%. Comparing base (
32a3339
) to head (df135c3
). Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3561 +/- ##
===========================================
- Coverage 55.35% 17.83% -37.53%
===========================================
Files 149 175 +26
Lines 8971 29046 +20075
===========================================
+ Hits 4966 5180 +214
- Misses 3666 23527 +19861
Partials 339 339
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/retest
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Closing as it looks like this was addressed in #3653
#3653 is changing failurePolicy
only on a single webhook. Comparing to this PR which fixes all of them.