aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Include target-type annotation in IngressClassParams

Open myoussef01 opened this issue 1 year ago • 5 comments

Is your feature request related to a problem? Currently, the only way to set the target-type is through the Ingress annotation: alb.ingress.kubernetes.io/target-type: ip

This makes each declarative Ingress unnecessarily verbose even when using a custom IngressClass + IngressClassParams.

Describe the solution you'd like Include it as a spec parameter within the IngressClassParams.

Describe alternatives you've considered This can also be an annotation on the custom IngressClass.

myoussef01 avatar Dec 26 '23 16:12 myoussef01

/kind feature Its a good suggestion. Will look into this if we can support this.

shraddhabang avatar Jan 17 '24 21:01 shraddhabang

/good first issue

shraddhabang avatar Jan 17 '24 23:01 shraddhabang

/assign @arcezd

arcezd avatar Feb 05 '24 23:02 arcezd

Hey @arcezd, are you still working on this issue? I want to try it if you are not interested in this issue.

prashantrewar avatar Mar 09 '24 14:03 prashantrewar

Hi @prashantrewar, I haven't done a lot of progress here, feel free to assign it to you and give it a try.

arcezd avatar Mar 12 '24 04:03 arcezd

/assign

Thankyou @arcezd.

prashantrewar avatar Mar 14 '24 17:03 prashantrewar

Hey @myoussef01, Could you please guide me on this issue?

prashantrewar avatar Mar 14 '24 17:03 prashantrewar

/unassign @arcezd

prashantrewar avatar Mar 14 '24 17:03 prashantrewar

Hi @shraddhabang , Is this issue still open for contribution ?

parambath92 avatar Jul 03 '24 19:07 parambath92

@prashantrewar Are you still working on this issue? If not, Could you please unassign yourself and let @parambath92 take this one as he is interested?

shraddhabang avatar Jul 08 '24 16:07 shraddhabang

/assign @parambath92

prashantrewar avatar Jul 08 '24 16:07 prashantrewar