aws-fsx-csi-driver icon indicating copy to clipboard operation
aws-fsx-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Make Volume resizing/creation timeout scale with volume size

Open jonded94 opened this issue 7 months ago • 6 comments

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Hopefully solves Issue: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/issues/382

Increases volume creation/resizing timeout by introducing an additional linear factor for waiting longer on larger volumes.

This was done based on datapoints that @jon-rei gathered in this comment. I made a crude linear regression onto these datapoints:

image

The resulting formula for timeout would be (T timeout [s], v volume size in GiB): T(v) = 454 + 2.18 * 10^(-3)*v So round about 7.5 min statically and for every GiB, we'd have to wait ~2ms additionally. I used 10 min statically and 5ms for every GiB to be on the safer side.

What testing is done?

None unfortunately, I don't have an easy way of testing this.

jonded94 avatar Jul 04 '24 18:07 jonded94