aws-encryption-provider
aws-encryption-provider copied to clipboard
kubernetes-sigs
Delete vendor directory
Hi @jngo2. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jngo2
Once this PR has been reviewed and has the lgtm label, please assign micahhausler for approval by writing /assign @micahhausler in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jngo2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-aws-encryption-provider-unittest | a1bedebb14d4b993212cb559a8087eddfbe474aa | link | true | /test pull-aws-encryption-provider-unittest |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@jngo2 I think you'll have to fix some of the test expectations about vendored code
@jngo2: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@xdu31: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jngo2 Need to change on lint target in makefile top resolve pull-aws-encryption-provider-verify: https://github.com/kubernetes-sigs/aws-encryption-provider/blob/master/Makefile#L10-L11 as part of the prow job definition in https://github.com/kubernetes/test-infra/blob/f7e21a3c18f4f4bbc7ee170675ed53e4544a[…]ig/jobs/kubernetes-sigs/aws-encryption-provider/presubmits.yaml
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jngo2, micahhausler
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [micahhausler]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment