aws-encryption-provider icon indicating copy to clipboard operation
aws-encryption-provider copied to clipboard
verified publisher icon kubernetes-sigs

Update golangci-lint to fix aws-sdk-go-v2 linting issues

Open mjlshen opened this issue 1 year ago • 2 comments

  • We have been pinning to older versions of many golangci-lint packages that are no longer needed
  • Updated golangci-lint to v1.61.0 and change a deprecated --deadline flag to --timeout
  • Resolve linter errors - mostly this is ignoring staticcheck for KMSv1 code that's being carried

Resolves CI linting failures in #120 but depends on #121 to merge first to fix a separate CI issue

mjlshen avatar Oct 08 '24 15:10 mjlshen

/lgtm /approve

micahhausler avatar Feb 05 '25 16:02 micahhausler

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 05 '25 16:02 k8s-ci-robot