aws-encryption-provider icon indicating copy to clipboard operation
aws-encryption-provider copied to clipboard
verified publisher icon kubernetes-sigs

Fix goreleaser --skip-publish flag deprecation

Open mjlshen opened this issue 1 year ago • 4 comments

  • --skip-publish was replaced with --skip=publish
  • --rm-dist was replaced with --clean

https://goreleaser.com/deprecations/#-skip https://goreleaser.com/deprecations/#-rm-dist

This resolves the CI failure in #120

mjlshen avatar Oct 08 '24 14:10 mjlshen

/lgtm

kmala avatar Oct 15 '24 23:10 kmala

@kmala: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 15 '24 23:10 k8s-ci-robot

@xdu31 / @wongma7 Do either of you have cycles to review this?

mjlshen avatar Oct 24 '24 01:10 mjlshen

/lgtm

kmala avatar Nov 01 '24 21:11 kmala

/approve

kmala avatar Nov 01 '24 21:11 kmala

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala, micahhausler, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 12 '24 18:11 k8s-ci-robot