aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
kubernetes-sigs
Helm charts prefix image names with containerRegistry
Added .values.containerRegistry to the values.yaml file, and prefixed all our images with the container registry. Also modifed the csi driver image to pull from the aws public ecr instead of dockerhub.
This will require updating the helm installation documentation here as well: https://docs.aws.amazon.com/eks/latest/userguide/efs-csi.html.
Is this a bug fix or adding new feature? New feature
What is this PR about? / Why do we need it? We need to be able to prefix all the images (sidecars + csi driver image )when using private ECR registries.
What testing is done? Deployed the helm chart without configuring any of the default values in values.yaml and made sure images pulled successfully.
Hi @RyanStan. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: RyanStan Once this PR has been reviewed and has the lgtm label, please assign leakingtapan for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Oh. Figured out why the tests were failing.
/home/prow/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/hack/e2e/csi-test-artifacts/bin/helm upgrade --install aws-efs-csi-driver --namespace kube-system --set image.repository=607362164682.dkr.ecr.us-west-2.amazonaws.com/aws-efs-csi-driver --set image.tag=22696 --wait --kubeconfig /home/prow/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/hack/e2e/csi-test-artifacts/test-cluster-22696.k8s.local.kops.kubeconfig ./charts/aws-efs-csi-driver -f ./hack/values.yaml
Release "aws-efs-csi-driver" does not exist. Installing it now.
The value passed in to image will break how this works now. This is a good call out that we'll have to modify our public documentation along with this PR when it's merged
@RyanStan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-aws-efs-csi-driver-e2e | 6141314cb47a981aaa278e846ee3866a399960ac | link | true | /test pull-aws-efs-csi-driver-e2e |
| pull-aws-efs-csi-driver-external-test-eks | 6141314cb47a981aaa278e846ee3866a399960ac | link | true | /test pull-aws-efs-csi-driver-external-test-eks |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
I would love if this lands so I we can install this SW from AWS ECR instead of downloading the image from DockerHub... all things considered, this AWS specific SW should be installed from AWS ECR since it is likely running on AWS EKS clusters..
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.