aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

feat: add support for additional pod labels

Open jaygridley opened this issue 2 years ago • 11 comments

Is this a bug fix or adding new feature? Feature

What is this PR about? / Why do we need it? Extends Helm chart with additional Pod labels capability

What testing is done? Locally generated template from the Helm chart

jaygridley avatar Feb 20 '23 17:02 jaygridley

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: jaygridley / name: Martin Odstrčilík (8eb360aa22873ce5204add25911070276c1ea18c)

linux-foundation-easycla[bot] avatar Feb 20 '23 17:02 linux-foundation-easycla[bot]

Hi @jaygridley. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 20 '23 17:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaygridley Once this PR has been reviewed and has the lgtm label, please assign leakingtapan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 20 '23 17:02 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 30 '23 00:05 k8s-triage-robot

/remove-lifecycle stale

jaygridley avatar May 30 '23 09:05 jaygridley

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 31 '23 11:05 k8s-ci-robot

Hello @nckturner and @wongma7 can we please get a review here?

gadiener avatar Jul 20 '23 07:07 gadiener

This change seems very straight forward and would help the thousands of users who are trying to do cost management and attribution for different aspects using labels. Many of our cost and inventory reporting tools use labels to do aggregation and visibility and labels are the way we can do that with ease. Thank you for creating this recommendation and it seems like the Helm way to do this for Pods.

sellers avatar Sep 27 '23 13:09 sellers

Can we please get a review on this? This feature will be so helpful for us

bharathiram avatar Dec 04 '23 20:12 bharathiram

@nckturner, @wongma7 any chance you can look into that?

gadiener avatar Feb 06 '24 09:02 gadiener