aws-efs-csi-driver
aws-efs-csi-driver copied to clipboard
kubernetes-sigs
Should not pass in mount option of awscredsuri
Is this a bug fix or adding new feature?
Should not pass in mount option of awscredsuri as there is no EKS customer should be using it, the uri is used together with ECS metadata endpoint. We should ignore that option if customer passed it in efs-csi-driver.
What is this PR about? / Why do we need it?
What testing is done?
@wangnyue: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Ashley-wenyizha, wangnyue, yinsihaws
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Ashley-wenyizha]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
After running hack/update-gofmt, pull-aws-efs-csi-driver-verify still fails, similar in https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/752
failed test was able to be fixed updating Go to latest version and run /hack/update-gofmt
Added on above comment:
- Can we add some unit test for this change? Basically validating when the option is passed, the csi-driver won't fail the mount but post a warn log, or that option is not passed to efs-utils at all.
- I think we should ignore the netns option as well, but that could be in a separate PR.
